chrome/browser/translate/translate_manager_browsertest.cc - Issue 23708004: Translate: Remove --enable-translate-settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 23708004: Translate: Remove --enable-translate-settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modify TranslateManagerBrowserTest.NeverTranslateLanguagePref Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/translate/translate_manager_browsertest.cc

diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc

index c7a9b3fa211d7acf6e61b91dd786628b34a8c714..60e42e635e9d19892cbe98c45f7eff0faf742685 100644

--- a/chrome/browser/translate/translate_manager_browsertest.cc

+++ b/chrome/browser/translate/translate_manager_browsertest.cc

@@ -1028,12 +1028,12 @@ TEST_F(TranslateManagerBrowserTest, NeverTranslateLanguagePref) {

PrefService* prefs = profile->GetPrefs();

PrefChangeRegistrar registrar;

registrar.Init(prefs);

- registrar.Add(TranslatePrefs::kPrefTranslateLanguageBlacklist,

+ registrar.Add(TranslatePrefs::kPrefTranslateBlockedLanguages,

pref_callback_);

TranslatePrefs translate_prefs(prefs);

EXPECT_FALSE(translate_prefs.IsBlockedLanguage("fr"));

EXPECT_TRUE(translate_prefs.CanTranslateLanguage(profile, "fr"));

- SetPrefObserverExpectation(TranslatePrefs::kPrefTranslateLanguageBlacklist);

+ SetPrefObserverExpectation(TranslatePrefs::kPrefTranslateBlockedLanguages);

translate_prefs.BlockLanguage("fr");

EXPECT_TRUE(translate_prefs.IsBlockedLanguage("fr"));

EXPECT_FALSE(translate_prefs.IsSiteBlacklisted(url.host()));

@@ -1048,7 +1048,7 @@ TEST_F(TranslateManagerBrowserTest, NeverTranslateLanguagePref) {

EXPECT_TRUE(GetTranslateInfoBar() == NULL);

// Remove the language from the blacklist.

- SetPrefObserverExpectation(TranslatePrefs::kPrefTranslateLanguageBlacklist);

+ SetPrefObserverExpectation(TranslatePrefs::kPrefTranslateBlockedLanguages);

translate_prefs.UnblockLanguage("fr");

EXPECT_FALSE(translate_prefs.IsBlockedLanguage("fr"));

EXPECT_FALSE(translate_prefs.IsSiteBlacklisted(url.host()));