Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23708004: Translate: Remove --enable-translate-settings (Closed)

Created:
7 years, 3 months ago by hajimehoshi
Modified:
7 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Translate: Remove --enable-translate-settings Now remove the flag and make this settings default. BUG=243235 TEST=browser_tests --gtest_filter=TranslateManagerBrowserTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220543

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : (Rebasing) #

Patch Set 4 : Modify TranslateManagerBrowserTest.NeverTranslateLanguagePref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -151 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/language_options.css View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/language_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_accept_languages.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_prefs.cc View 6 chunks +23 lines, -61 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hajimehoshi
estade@, can you take a look at chrome/browser/resources/* and chrome/browser/ui/*? toyoshim@, can you take a ...
7 years, 3 months ago (2013-08-29 06:11:35 UTC) #1
Evan Stade
lgtm
7 years, 3 months ago (2013-08-30 01:05:11 UTC) #2
Takashi Toyoshima
Please fix NeverTranslateLanguagePref test.
7 years, 3 months ago (2013-08-30 01:37:41 UTC) #3
hajimehoshi
On 2013/08/30 01:37:41, Takashi Toyoshima (chromium) wrote: > Please fix NeverTranslateLanguagePref test. Done. Thanks.
7 years, 3 months ago (2013-08-30 05:24:48 UTC) #4
Takashi Toyoshima
lgtm.
7 years, 3 months ago (2013-08-30 06:01:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/23708004/19001
7 years, 3 months ago (2013-08-30 06:31:41 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 09:15:07 UTC) #7
Message was sent while issue was closed. 
Change committed as 220543

Powered by Google App Engine
This is Rietveld 408576698