src/effects/gradients/SkGradientShaderPriv.h - Issue 23706003: Fix case where GrGLEffectMatrix gives back a dangling ptr for the coords var name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkGradientShaderPriv.h

Issue 23706003: Fix case where GrGLEffectMatrix gives back a dangling ptr for the coords var name. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Rob's comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/gradients/SkGradientShaderPriv.h

diff --git a/src/effects/gradients/SkGradientShaderPriv.h b/src/effects/gradients/SkGradientShaderPriv.h

index 31cc9f26171c6184b4535004ea1388d2de024bc4..8e9360429fea3c0fac6146a1dc8d0123ba3b90d5 100644

--- a/src/effects/gradients/SkGradientShaderPriv.h

+++ b/src/effects/gradients/SkGradientShaderPriv.h

@@ -317,8 +317,8 @@ protected:

void setupMatrix(GrGLShaderBuilder* builder,

EffectKey key,

- const char** fsCoordName,

- const char** vsVaryingName = NULL,

+ SkString* fsCoordName,

+ SkString* vsVaryingName = NULL,

GrSLType* vsVaryingType = NULL);

// Emits the uniform used as the y-coord to texture samples in derived classes. Subclasses

« no previous file with comments | « src/effects/gradients/SkGradientShader.cpp ('k') | src/effects/gradients/SkLinearGradient.cpp » ('j') | no next file with comments »