src/effects/gradients/SkGradientShader.cpp - Issue 23706003: Fix case where GrGLEffectMatrix gives back a dangling ptr for the coords var name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkGradientShader.cpp

Issue 23706003: Fix case where GrGLEffectMatrix gives back a dangling ptr for the coords var name. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Rob's comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/gradients/SkGradientShader.cpp

diff --git a/src/effects/gradients/SkGradientShader.cpp b/src/effects/gradients/SkGradientShader.cpp

index 2c554dc37605ad6a24b5a281523094f2b4e13b61..329e6c76cedd020ae3e77f95ee267efbe7de1f4c 100644

--- a/src/effects/gradients/SkGradientShader.cpp

+++ b/src/effects/gradients/SkGradientShader.cpp

@@ -857,8 +857,8 @@ GrGLEffect::EffectKey GrGLGradientEffect::GenMatrixKey(const GrDrawEffect& drawE

void GrGLGradientEffect::setupMatrix(GrGLShaderBuilder* builder,

EffectKey key,

- const char** fsCoordName,

- const char** vsVaryingName,

+ SkString* fsCoordName,

+ SkString* vsVaryingName,

GrSLType* vsVaryingType) {

fEffectMatrix.emitCodeMakeFSCoords2D(builder,

key & kMatrixKeyMask,

« no previous file with comments | « src/effects/SkPerlinNoiseShader.cpp ('k') | src/effects/gradients/SkGradientShaderPriv.h » ('j') | no next file with comments »