[blink] Use functions for AllMarkers and MisspellingMarkers

[blink] Use functions for AllMarkers and MisspellingMarkers

This patch changes AllMarkers and MisspellingMarkers to be functions
instead of subclasses of MarkerTypes. This avoids a vtable.

Suggested by tony@chromium.org.

BUG=295190

[please use gerrit instead, 2013-09-20 18:00:20]

Tony: PTAL. You suggested this change in
https://codereview.chromium.org/24198006.

[tony, 2013-09-20 18:10:28]

I'm full of lies, the size is the same.  There's no vtable because nothing is
virtual.

Up to you whether to land this or not.  It's a bit less code this way, but I
don't feel strongly one way or another.

LGTM

https://codereview.chromium.org/23703016/diff/1/Source/core/dom/DocumentMarker.h
File Source/core/dom/DocumentMarker.h (right):

https://codereview.chromium.org/23703016/diff/1/Source/core/dom/DocumentMarke...
Source/core/dom/DocumentMarker.h:50: MarkerTypes(unsigned mask) : m_mask(mask) {
}
Nit: explicit

[tony, 2013-09-20 18:10:41]

Sorry for the extra work.

[please use gerrit instead, 2013-09-20 18:19:47]

No problem. If there's no benefit, then I will not land.

[please use gerrit instead, 2013-09-20 18:20:29]

https://codereview.chromium.org/23703016/diff/1/Source/core/dom/DocumentMarker.h
File Source/core/dom/DocumentMarker.h (right):

https://codereview.chromium.org/23703016/diff/1/Source/core/dom/DocumentMarke...
Source/core/dom/DocumentMarker.h:50: MarkerTypes(unsigned mask) : m_mask(mask) {
}
On 2013/09/20 18:10:28, tony wrote:
> Nit: explicit

The comment says that "the constructor is intentionally implicit to allow
conversion from the bit-wise sum of types."