Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2212)

Unified Diff: chrome/common/extensions/permissions/socket_permission_unittest.cc

Issue 23703008: Add network-status socket permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ' Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/permissions/socket_permission_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/socket_permission_unittest.cc
diff --git a/chrome/common/extensions/permissions/socket_permission_unittest.cc b/chrome/common/extensions/permissions/socket_permission_unittest.cc
index 51a36c8cdc9c9a843e63ebd57f056625761aedf6..8d75d73a638e4473e7de09dd2a24c51c62252e34 100644
--- a/chrome/common/extensions/permissions/socket_permission_unittest.cc
+++ b/chrome/common/extensions/permissions/socket_permission_unittest.cc
@@ -249,6 +249,17 @@ TEST(SocketPermissionTest, Match) {
param.reset(new SocketPermission::CheckParam(
SocketPermissionRequest::TCP_CONNECT, "127.0.0.1", 8800));
EXPECT_FALSE(data.Check(param.get()));
+
+ ASSERT_TRUE(data.ParseForTest("network-state"));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::NETWORK_STATE, std::string(), 0));
+ EXPECT_TRUE(data.Check(param.get()));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::UDP_BIND, "127.0.0.1", 8800));
+ EXPECT_FALSE(data.Check(param.get()));
+ param.reset(new SocketPermission::CheckParam(
+ SocketPermissionRequest::TCP_CONNECT, "127.0.0.1", 8800));
+ EXPECT_FALSE(data.Check(param.get()));
}
TEST(SocketPermissionTest, IPC) {
« no previous file with comments | « chrome/common/extensions/permissions/socket_permission_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698