Add network-status socket permission.

Add network-status socket permission.

The new socket permission will be used when PPB_NetworkMonitor 
interface becomes public.

BUG=281781
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223564

[yzshen1, 2013-09-06 21:30:06]

lgtm

https://codereview.chromium.org/23703008/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/23703008/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:4228: +      <message
name="IDS_EXTENSION_PROMPT_WARNING_NETWORK_STATE" desc="Permission string
network list access.">
"Permission string _for_ ..." ?

https://codereview.chromium.org/23703008/diff/1/chrome/common/extensions/perm...
File chrome/common/extensions/permissions/socket_permission.cc (right):

https://codereview.chromium.org/23703008/diff/1/chrome/common/extensions/perm...
chrome/common/extensions/permissions/socket_permission.cc:102:
PermissionMessage::kNetworkState,
wrong indent.

[Sergey Ulanov, 2013-09-09 18:28:28]

https://codereview.chromium.org/23703008/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/23703008/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:4228: +      <message
name="IDS_EXTENSION_PROMPT_WARNING_NETWORK_STATE" desc="Permission string
network list access.">
On 2013/09/06 21:30:06, yzshen1 wrote:
> "Permission string _for_ ..." ?

Done.

https://codereview.chromium.org/23703008/diff/1/chrome/common/extensions/perm...
File chrome/common/extensions/permissions/socket_permission.cc (right):

https://codereview.chromium.org/23703008/diff/1/chrome/common/extensions/perm...
chrome/common/extensions/permissions/socket_permission.cc:102:
PermissionMessage::kNetworkState,
On 2013/09/06 21:30:06, yzshen1 wrote:
> wrong indent.

Done. Also fixed indent in couple of other places in this file.

[miket_OOO, 2013-09-11 17:15:59]

LGTM, but I'm not sure as an end user I'd have any idea what a "network
connection" is. Is it the same as the number of ethernet cables I have plugged
into my machine? Is it the number of programs talking to programs on other
machines? Is it the number of connected sockets?

[Sergey Ulanov, 2013-09-11 18:49:50]

On 2013/09/11 17:15:59, miket wrote:
> LGTM, but I'm not sure as an end user I'd have any idea what a "network
> connection" is. Is it the same as the number of ethernet cables I have plugged
> into my machine? Is it the number of programs talking to programs on other
> machines? Is it the number of connected sockets?

Yes, I agree it's not perfect. But I'm not sure if there is better wording for
it. It could say something like "list of network interfaces and their
parameters" to be less ambiguous, but normal users do not know what a "network
interface" is. FWIW: Android uses "view network connections" for similar
permission. Please let me know if you have suggestions for better wording.

[miket_OOO, 2013-09-11 21:28:33]

> Please let me know if you have suggestions for better wording.

I'm afraid I don't. Still LGTM.

[commit-bot: I haz the power, 2013-09-17 04:38:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23703008/15001

[commit-bot: I haz the power, 2013-09-17 07:50:30]

Change committed as 223564