Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 23702015: Add OpenGL 4.4 support to SkNativeGLContext and GrGLCreateNativeInterface android versions. (Closed)

Created:
7 years, 3 months ago by bsalomon
Modified:
7 years, 3 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com, Chris Dalton
Visibility:
Public.

Description

Add OpenGL 4.4 support to SkNativeGLContext and GrGLCreateNativeInterface android versions. Committed: http://code.google.com/p/skia/source/detail?r=11060

Patch Set 1 #

Patch Set 2 : Add dekstop setup initial version #

Patch Set 3 : Add dekstop setup initial version #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Total comments: 3

Patch Set 6 : updates #

Patch Set 7 : remove prints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -166 lines) Patch
M include/gpu/gl/GrGLInterface.h View 1 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 2 3 4 5 1 chunk +358 lines, -148 lines 0 comments Download
M src/gpu/gl/android/SkNativeGLContext_android.cpp View 1 2 3 4 5 6 3 chunks +52 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
https://codereview.chromium.org/23702015/diff/9001/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (right): https://codereview.chromium.org/23702015/diff/9001/include/gpu/gl/GrGLInterface.h#newcode220 include/gpu/gl/GrGLInterface.h:220: GLPtr<GrGLLoadIdentityProc> fLoadIdentity; We now actually check for these in ...
7 years, 3 months ago (2013-08-30 20:55:03 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/23702015/diff/14001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp File src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp (right): https://codereview.chromium.org/23702015/diff/14001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp#newcode19 src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:19: overlength https://codereview.chromium.org/23702015/diff/14001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp#newcode181 src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:181: overlength https://codereview.chromium.org/23702015/diff/14001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp#newcode182 src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:182: ...
7 years, 3 months ago (2013-08-31 14:10:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23702015/21002
7 years, 3 months ago (2013-09-03 15:11:53 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 17:50:54 UTC) #4
Message was sent while issue was closed.
Change committed as 11060

Powered by Google App Engine
This is Rietveld 408576698