media/mp4/mp4_stream_parser.cc - Issue 23702007: Render inband text tracks in the media pipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/mp4_stream_parser.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: incorporate aaron's comments (10/12) Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/mp4_stream_parser.cc

diff --git a/media/mp4/mp4_stream_parser.cc b/media/mp4/mp4_stream_parser.cc

index 26cee44d14e8c9d2ac99108d4c8e8f1c87fa3ef0..56ffdd057d348bfb79a27c927eb842021759f49e 100644

--- a/media/mp4/mp4_stream_parser.cc

+++ b/media/mp4/mp4_stream_parser.cc

@@ -45,7 +45,7 @@ void MP4StreamParser::Init(const InitCB& init_cb,

const NewBuffersCB& new_buffers_cb,

const NewTextBuffersCB& /* text_cb */ ,

const NeedKeyCB& need_key_cb,

- const AddTextTrackCB& /* add_text_track_cb */ ,

+ const NewTextTrackCB& /* new_text_track_cb */ ,

const NewMediaSegmentCB& new_segment_cb,

const base::Closure& end_of_segment_cb,

const LogCB& log_cb) {