media/tools/demuxer_bench/demuxer_bench.cc - Issue 23702007: Render inband text tracks in the media pipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/tools/demuxer_bench/demuxer_bench.cc

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: incorporate aaron's comments (9/28) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/tools/demuxer_bench/demuxer_bench.cc

diff --git a/media/tools/demuxer_bench/demuxer_bench.cc b/media/tools/demuxer_bench/demuxer_bench.cc

index ab8b313c435c1213eab9a676504c175bc4fc830b..e26f1ce4e5be42d0f4cfa1e28d5d00f3f4edf875 100644

--- a/media/tools/demuxer_bench/demuxer_bench.cc

+++ b/media/tools/demuxer_bench/demuxer_bench.cc

@@ -195,9 +195,11 @@ int main(int argc, char** argv) {

CHECK(data_source.Initialize(file_path));

media::Demuxer::NeedKeyCB need_key_cb = base::Bind(&NeedKey);

+ media::FFmpegAddTextTrackCB add_text_track_cb;

media::FFmpegDemuxer demuxer(message_loop.message_loop_proxy(),

&data_source,

need_key_cb,

+ add_text_track_cb,

acolwell GONE FROM CHROMIUM 2013/10/08 15:45:24 nit: I don't believe this compiles. I think you ne

Matthew Heaney (Chromium) 2013/10/13 05:30:17 Done.

new media::MediaLog());

demuxer.Initialize(&demuxer_host, base::Bind(