Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: content/renderer/media/webmediaplayer_impl.h

Issue 23702007: Render inband text tracks in the media pipeline (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporate aaron's comments (9/28) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webmediaplayer_impl.h
diff --git a/content/renderer/media/webmediaplayer_impl.h b/content/renderer/media/webmediaplayer_impl.h
index 270186bbbe5aad43fce9d7c4d3ee8a7c4977fab2..6d5ef08703c0815db0b7565317c21953c4513a62 100644
--- a/content/renderer/media/webmediaplayer_impl.h
+++ b/content/renderer/media/webmediaplayer_impl.h
@@ -20,6 +20,7 @@
#ifndef CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_IMPL_H_
#define CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_IMPL_H_
+#include <map>
acolwell GONE FROM CHROMIUM 2013/10/08 15:45:24 nit: no longer needed.
Matthew Heaney (Chromium) 2013/10/13 05:30:17 Done.
#include <string>
#include <vector>
@@ -55,9 +56,10 @@ class MessageLoopProxy;
namespace media {
class ChunkDemuxer;
-class FFmpegDemuxer;
+class DemuxerStream;
class GpuVideoAcceleratorFactories;
class MediaLog;
+class TextCue;
acolwell GONE FROM CHROMIUM 2013/10/08 15:45:24 nit: Not needed
Matthew Heaney (Chromium) 2013/10/13 05:30:17 Done.
}
namespace webkit {
@@ -197,9 +199,19 @@ class WebMediaPlayerImpl
void OnNeedKey(const std::string& type,
const std::string& session_id,
const std::vector<uint8>& init_data);
+ // TODO(matthewjheaney): Once we're satisfied that we have the threading model
+ // correct for handling text cues, move the media source from OnTextTrack over
+ // to AddTextStream.
acolwell GONE FROM CHROMIUM 2013/10/08 15:45:24 I'd like this fixed in this CL. Now that OnAddText
Matthew Heaney (Chromium) 2013/10/13 05:30:17 I modified the chunk demuxer and friends to handle
scoped_ptr<media::TextTrack> OnTextTrack(media::TextKind kind,
const std::string& label,
const std::string& language);
+
+ void OnAddTextStream(media::DemuxerStream*,
+ media::TextKind kind,
+ const std::string& label,
+ const std::string& language,
+ const media::AddTextTrackDoneCB& done_cb);
+
void SetOpaque(bool);
private:

Powered by Google App Engine
This is Rietveld 408576698