Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 23694049: Improved srcset descriptor parsing. (Closed)

Created:
7 years, 3 months ago by Yoav Weiss
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Improved srcset descriptor parsing. I've refactored srcset's descriptor parser in order to improve readability of the srcset parser, and improve spec compliance. Changes: * Descriptor parsing is now split to its own function. * Invalid descriptors are ignored, rather than invalidate the candidate. - That includes the viewport qualifiers, which are not yet supported, but may be used by authors. * Some unnecessary cruft has been removed from the srcset parser. * Added tests that make sure descriptors are treated as they should. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -35 lines) Patch
A LayoutTests/fast/hidpi/image-srcset-ignore-double-descriptor.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/hidpi/image-srcset-ignore-double-descriptor-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A + LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html View 2 chunks +1 line, -5 lines 0 comments Download
A + LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-viewport-modifiers.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-viewport-modifiers-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLSrcsetParser.cpp View 4 chunks +42 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yoav Weiss
I did some refactoring to the srcset parser, to make sure it is spec compliant ...
7 years, 3 months ago (2013-09-22 12:46:47 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-22 16:08:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/23694049/1
7 years, 3 months ago (2013-09-22 16:08:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/23694049/1
7 years, 3 months ago (2013-09-22 20:23:32 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-23 08:22:38 UTC) #5
Message was sent while issue was closed.
Change committed as 158167

Powered by Google App Engine
This is Rietveld 408576698