LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html - Issue 23694049: Improved srcset descriptor parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

Issue 23694049: Improved srcset descriptor parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-ignore-double-descriptor-expected.txt ('k') | LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

diff --git a/LayoutTests/fast/hidpi/image-srcset-simple-1x.html b/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

similarity index 73%

copy from LayoutTests/fast/hidpi/image-srcset-simple-1x.html

copy to LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

index b6c3f5f60285c2c7c787eb5f277fd4096ac2d126..46319b882370d0cd580fbc3bca43772d8341a14f 100644

--- a/LayoutTests/fast/hidpi/image-srcset-simple-1x.html

+++ b/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

@@ -6,10 +6,6 @@

- if (window.testRunner) {

- testRunner.dumpAsText();

- }

addEventListener("load", function() {

shouldBeTrue('document.getElementById("foo").clientWidth==400');

}, false);

@@ -18,6 +14,6 @@

<div>This test passes if the image below says 1x with a reddish background when the deviceScaleFactor is 1, and if says 2x with a greenish background when the deviceScaleFactor is 2.</div>

- <img id="foo" src="" srcset="resources/image-set-1x.png 1x, resources/deleteButton.png 3x, resources/image-set-2x.png 2x">

+ <img id="foo" src="" srcset="resources/image-set-1x.png 43q 1x dfs 3dd, resources/image-set-2x.png 2x">

</body>

</html>