Issue 23694012: drive: Stop using resource ID to access local metadata in GetFileForSavingOpreation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23694012: drive: Stop using resource ID to access local metadata in GetFileForSavingOpreation (Closed)

Created:
7 years, 3 months ago by hashimoto

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Stop using resource ID to access local metadata in GetFileForSavingOpreation BUG=275270 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220747

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -16 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc	View	6 chunks	+26 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc	View	5 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/23694012/1

7 years, 3 months ago (2013-08-31 02:40:44 UTC) #3

Message was sent while issue was closed.

Change committed as 220747

Expand Messages | Collapse Messages