DevTools: [Workspace] show network files in navigator

DevTools: [Workspace] show network files in navigator

This patch starts showing network files in navigator even when they are
mapped against certain file system files.

BUG=649837
R=dgozman, pfeldman

Committed: https://crrev.com/914ea91587cc89b555178c6f65e570c42bae9ad4
Cr-Commit-Position: refs/heads/master@{#421597}

[lushnikov, 2016-09-26 19:36:08]

lushnikov@chromium.org changed reviewers:
- dgozman@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-09-26 19:36:08]

Please, take a look 

Screenshot: http://imgur.com/a/7mUf6

[lushnikov, 2016-09-26 23:43:21]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-09-26 23:44:32]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 23:45:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:13:30]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-27 17:08:47]

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt
(right):

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt:37:
inspector/persistence/resources
Let's dump the dimmed state as well.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:809: var
title1 = /** @type {string} */(treeElement1.title instanceof Element ?
treeElement1.title.textContent : treeElement1.title);
titleAsText

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1258:
WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingCreated,
updateTitleBound),
Should not listen for this on every tree node.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1282:
status.textContent = "◉";
\uxxxx

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1283: if
(this._uiSourceCode === binding.network)
Let's trim urls.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1284:
status.title = WebInspector.UIString("Mapped to fileSystem: %s",
binding.fileSystem.url());
Persisted to file system: %s

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1286:
status.title = WebInspector.UIString("Mapped to source map: %s",
binding.network.url());
Linked to source map: %s

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1288:
status.title = WebInspector.UIString("Mapped to network: %s",
binding.network.url());
Linked to %s

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1424:
WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingCreated,
this._updateHasMappedFiles, this),
Make it global.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1604:
WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingCreated,
this._updateHasMappedFiles, this),
ditto

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1626:
dispose: function()
@override ?

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css
(right):

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css:49:
.navigator-fs-tree-item,
.navigator-fs-tree-item:not(.has-mapped-files)

[lushnikov, 2016-09-27 21:29:13]

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt
(right):

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt:37:
inspector/persistence/resources
On 2016/09/27 17:08:47, dgozman wrote:
> Let's dump the dimmed state as well.

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:809: var
title1 = /** @type {string} */(treeElement1.title instanceof Element ?
treeElement1.title.textContent : treeElement1.title);
On 2016/09/27 17:08:47, dgozman wrote:
> titleAsText

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1258:
WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingCreated,
updateTitleBound),
On 2016/09/27 17:08:47, dgozman wrote:
> Should not listen for this on every tree node.

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1282:
status.textContent = "◉";
On 2016/09/27 17:08:47, dgozman wrote:
> \uxxxx

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1283: if
(this._uiSourceCode === binding.network)
On 2016/09/27 17:08:47, dgozman wrote:
> Let's trim urls.

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1284:
status.title = WebInspector.UIString("Mapped to fileSystem: %s",
binding.fileSystem.url());
On 2016/09/27 17:08:47, dgozman wrote:
> Persisted to file system: %s

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1286:
status.title = WebInspector.UIString("Mapped to source map: %s",
binding.network.url());
On 2016/09/27 17:08:47, dgozman wrote:
> Linked to source map: %s

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1288:
status.title = WebInspector.UIString("Mapped to network: %s",
binding.network.url());
On 2016/09/27 17:08:47, dgozman wrote:
> Linked to %s

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1424:
WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingCreated,
this._updateHasMappedFiles, this),
On 2016/09/27 17:08:47, dgozman wrote:
> Make it global.

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1604:
WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingCreated,
this._updateHasMappedFiles, this),
On 2016/09/27 17:08:47, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1626:
dispose: function()
On 2016/09/27 17:08:47, dgozman wrote:
> @override ?

Done.

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css
(right):

https://codereview.chromium.org/2369173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css:49:
.navigator-fs-tree-item,
On 2016/09/27 17:08:47, dgozman wrote:
> .navigator-fs-tree-item:not(.has-mapped-files)

Done.

[lushnikov, 2016-09-27 21:29:30]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 21:29:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 22:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:35:46]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-28 16:27:21]

lgtm

https://codereview.chromium.org/2369173002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2369173002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:165: //
Update UISourceCode titles.
nit: previous empty line and this comment look strange

https://codereview.chromium.org/2369173002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:175: for
(var token of pathTokens) {
Let's iterate over everything except last one.

[lushnikov, 2016-09-28 18:11:44]

https://codereview.chromium.org/2369173002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2369173002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:165: //
Update UISourceCode titles.
On 2016/09/28 16:27:21, dgozman wrote:
> nit: previous empty line and this comment look strange

Done.

https://codereview.chromium.org/2369173002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:175: for
(var token of pathTokens) {
On 2016/09/28 16:27:21, dgozman wrote:
> Let's iterate over everything except last one.

Done.

https://codereview.chromium.org/2369173002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2369173002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:1630:
onattach: function()
The logic in updateTitle which expands active file system doesn't work on
navigator initial construction.

The reason is that WebInspector.NavigatorGroupTreeNode has .collapse in
onattach. This change fixes it.

[lushnikov, 2016-09-28 18:14:28]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-09-28 18:14:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2369173002/#ps100001
(title: "address comments + improvement")

[commit-bot: I haz the power, 2016-09-28 18:14:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 19:15:40]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-28 19:18:44]

Description was changed from

==========
DevTools: [Workspace] show network files in navigator

This patch starts showing network files in navigator even when they are
mapped against certain file system files.

BUG=649837
R=dgozman, pfeldman
==========

to

==========
DevTools: [Workspace] show network files in navigator

This patch starts showing network files in navigator even when they are
mapped against certain file system files.

BUG=649837
R=dgozman, pfeldman

Committed: https://crrev.com/914ea91587cc89b555178c6f65e570c42bae9ad4
Cr-Commit-Position: refs/heads/master@{#421597}
==========

[commit-bot: I haz the power, 2016-09-28 19:18:45]

Patchset 6 (id:??) landed as
https://crrev.com/914ea91587cc89b555178c6f65e570c42bae9ad4
Cr-Commit-Position: refs/heads/master@{#421597}