Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3415)

Unified Diff: net/quic/quic_packet_generator.cc

Issue 23691073: Land Recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compiler/unittests fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_generator.h ('k') | net/quic/quic_packet_generator_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_generator.cc
diff --git a/net/quic/quic_packet_generator.cc b/net/quic/quic_packet_generator.cc
index 46500689e0d5e3a538e1867705f488d33342f555..9151cb883b3c66bed7e10bf281edbbbd673c70b7 100644
--- a/net/quic/quic_packet_generator.cc
+++ b/net/quic/quic_packet_generator.cc
@@ -70,13 +70,6 @@ void QuicPacketGenerator::AddControlFrame(const QuicFrame& frame) {
QuicConsumedData QuicPacketGenerator::ConsumeData(QuicStreamId id,
StringPiece data,
QuicStreamOffset offset,
- bool fin) {
- return ConsumeData(id, data, offset, fin, NULL);
-}
-
-QuicConsumedData QuicPacketGenerator::ConsumeData(QuicStreamId id,
- StringPiece data,
- QuicStreamOffset offset,
bool fin,
QuicAckNotifier* notifier) {
IsHandshake handshake = id == kCryptoStreamId ? IS_HANDSHAKE : NOT_HANDSHAKE;
@@ -203,7 +196,7 @@ bool QuicPacketGenerator::HasPendingFrames() const {
bool QuicPacketGenerator::AddNextPendingFrame() {
if (should_send_ack_) {
- pending_ack_frame_.reset((delegate_->CreateAckFrame()));
+ pending_ack_frame_.reset(delegate_->CreateAckFrame());
// If we can't this add the frame now, then we still need to do so later.
should_send_ack_ = !AddFrame(QuicFrame(pending_ack_frame_.get()));
// Return success if we have cleared out this flag (i.e., added the frame).
@@ -212,7 +205,7 @@ bool QuicPacketGenerator::AddNextPendingFrame() {
}
if (should_send_feedback_) {
- pending_feedback_frame_.reset((delegate_->CreateFeedbackFrame()));
+ pending_feedback_frame_.reset(delegate_->CreateFeedbackFrame());
// If we can't this add the frame now, then we still need to do so later.
should_send_feedback_ = !AddFrame(QuicFrame(pending_feedback_frame_.get()));
// Return success if we have cleared out this flag (i.e., added the frame).
« no previous file with comments | « net/quic/quic_packet_generator.h ('k') | net/quic/quic_packet_generator_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698