Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 23691073: Land Recent QUIC changes. (Closed)

Created:
7 years, 3 months ago by ramant (doing other things)
Modified:
7 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Visibility:
Public.

Description

Land Recent QUIC changes. Added a DCHECK that ProcessRawData will not be called with zero data length. Merge internal change: 52068687 Removed reinterpret_cast<QuicFecBuilderInterface*>. Minor comment fix. Merge internal change: 52051673 Replace QuicConnectionVisitorInterface::OnPacket with OnStreamFrames Merge internal change: 52049491 Remove unused OnAck method from QuicConnectionVisitorInterface. This is a bit of an abstraction violation, since nothing above the Connection knows about packets. The AckNotifier interface provides the "right" abstraction. Merge internal change: 52027657 Add state to session to indicate that a crypto stream is blocked, so that we can properly set the IS_HANDSHAKE argument when asking the congestion manager if we CanWrite(). Merge internal change: 51983405 Break out the tracking of sent packet from QuicConnection to a new QuicSentPacketManager class. Merge internal change: 51969314 Delay the RTO every time an ack is received, per TCP RTO spec. Merge internal change: 51954312 Sending ConnectionClose frames via the PacketGenerator so they get properly queued if they cannot be sent immediately. Prevents multiple different connection close packets from being sent, a potential infinite loop, and from dropping connection close packets which can't be sent due to a write block from being dropped entirely. Merge internal change: 51890780 Increse the default max_tcp_congestion_window to 100 from 50, now that the RTO has been increased to the TCP standard of 60 seconds. Merge internal change: 51854728 Added large (1 Mb) POST tests. Verified that without the fix from cl/51829697 these tests timeout due to receiver cwnd dropping to zero after sending ACKs. Merge internal change: 51854636 Refactored and replaced SendStreamAndNotifyWhenAck() to work with SendvStreamData(). Merge internal change: 51848330 Remove unused client2 scoped_ptrs from end_to_end_tests Merge internal change: 51835589 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223996

Patch Set 1 : Land Recent QUIC changes. #

Patch Set 2 : Merge with priority changes #

Patch Set 3 : compile fixes #

Patch Set 4 : Compiler/unittests fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1009 lines, -538 lines) Patch
M net/base/linked_hash_map.h View 4 chunks +6 lines, -6 lines 0 comments Download
M net/net.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/quic_congestion_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.h View 16 chunks +47 lines, -39 lines 0 comments Download
M net/quic/quic_connection.cc View 1 2 27 chunks +177 lines, -272 lines 0 comments Download
M net/quic/quic_connection_helper_test.cc View 10 chunks +26 lines, -15 lines 0 comments Download
M net/quic/quic_connection_test.cc View 38 chunks +88 lines, -70 lines 0 comments Download
M net/quic/quic_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_generator.h View 2 chunks +12 lines, -12 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 11 chunks +13 lines, -13 lines 0 comments Download
A net/quic/quic_sent_packet_manager.h View 1 2 1 chunk +140 lines, -0 lines 0 comments Download
A net/quic/quic_sent_packet_manager.cc View 1 chunk +221 lines, -0 lines 0 comments Download
A net/quic/quic_sent_packet_manager_test.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 3 chunks +7 lines, -6 lines 0 comments Download
M net/quic/quic_session.cc View 9 chunks +33 lines, -28 lines 0 comments Download
M net/quic/quic_session_test.cc View 8 chunks +84 lines, -18 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 4 chunks +6 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 3 3 chunks +25 lines, -3 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 6 chunks +13 lines, -4 lines 0 comments Download
M net/tools/quic/quic_reliable_server_stream_test.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 6 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ramant (doing other things)
7 years, 3 months ago (2013-09-17 22:18:54 UTC) #1
ramant (doing other things)
Hi Ryan, This CL has all the CL's you have LGTM'ed after what was already ...
7 years, 3 months ago (2013-09-17 22:25:10 UTC) #2
Ryan Hamilton
lgtm since i have reviewd all the individual changes.
7 years, 3 months ago (2013-09-18 03:39:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23691073/8001
7 years, 3 months ago (2013-09-18 15:44:41 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-18 16:00:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23691073/8001
7 years, 3 months ago (2013-09-18 16:50:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23691073/26001
7 years, 3 months ago (2013-09-18 17:00:27 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-18 17:05:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23691073/41001
7 years, 3 months ago (2013-09-18 18:07:59 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 23:54:49 UTC) #10
Message was sent while issue was closed.
Change committed as 223996

Powered by Google App Engine
This is Rietveld 408576698