Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 23691069: V8 Buildbot: Make testing i18n the default. (Closed)

Created:
7 years, 3 months ago by Michael Achenbach
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Visibility:
Public.

Description

V8 Buildbot: Make testing i18n the default. Internationalization support will be turned on by default on all bots with https://codereview.chromium.org/23003028. This CL cleans up old explicit intl tests, turns off intl tests on nacl and transforms the old intl tester into a non-intl tester. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=223826

Patch Set 1 : #

Patch Set 2 : Deactivate i18n for nacl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M masters/master.client.v8/master.cfg View 1 7 chunks +16 lines, -12 lines 0 comments Download
M masters/master.client.v8/master_gatekeeper_cfg.py View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.client.v8/slaves.cfg View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/master/factory/v8_commands.py View 1 1 chunk +0 lines, -8 lines 0 comments Download
M scripts/master/factory/v8_factory.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/v8/v8testing.py View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 3 months ago (2013-09-17 11:45:02 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 3 months ago (2013-09-17 12:50:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/23691069/6001
7 years, 3 months ago (2013-09-18 09:03:14 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 09:04:08 UTC) #4
Message was sent while issue was closed.
Change committed as 223826

Powered by Google App Engine
This is Rietveld 408576698