Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 23691039: Reland attempt 2: Improve <webview> autosize: (Closed)

Created:
7 years, 3 months ago by lazyboy
Modified:
7 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reland attempt 2: Improve <webview> autosize: a. Expand/shrink <webview> element when 'sizechange' event fires, to match with the new view size (in shim). b. For SW mode, fix a bug where damage buffer would remain smaller than the view size and would result in crash. Added test for this case. BUG=173238, 282116 Test=WebViewTest.AutoSize.*, <webview>.autosize=true now should autosize webview container within the constraints (minwidth/maxwidth/minheight/maxheight). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221402

Patch Set 1 #

Patch Set 2 : Fix the test, reland changes are changes in patcheset #2. #

Patch Set 3 : Relax checking width/height since bunch of removeAttribute() and style.width assignments are not at… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -70 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 4 chunks +27 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 3 chunks +73 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/autosize/main.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/autosize/main.js View 1 chunk +63 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/autosize/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/autosize/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 2 2 chunks +16 lines, -24 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 2 chunks +10 lines, -6 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 13 chunks +61 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lazyboy
Charlie, can you rubberstamp this reland CL? (OWNERS for content/renderer/browser_plugin/* and content/browser/browser_plugin/*) Patchset #1 was ...
7 years, 3 months ago (2013-09-04 19:24:20 UTC) #1
Charlie Reis
Rubber stamp LGTM for content/. You'll probably need an owner's review for chrome/.
7 years, 3 months ago (2013-09-04 20:04:42 UTC) #2
lazyboy
On 2013/09/04 20:04:42, creis wrote: > Rubber stamp LGTM for content/. You'll probably need an ...
7 years, 3 months ago (2013-09-04 20:09:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/23691039/14001
7 years, 3 months ago (2013-09-05 01:16:31 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-05 01:39:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/23691039/14001
7 years, 3 months ago (2013-09-05 07:47:52 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 13:16:36 UTC) #7
Message was sent while issue was closed.
Change committed as 221402

Powered by Google App Engine
This is Rietveld 408576698