content/browser/browser_plugin/browser_plugin_guest.cc - Issue 23691039: Reland attempt 2: Improve <webview> autosize:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 23691039: Reland attempt 2: Improve <webview> autosize: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Relax checking width/height since bunch of removeAttribute() and style.width assignments are not at… Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index fedd64da88655b27d4c30a91fdad47d6cdb98f65..9408e7606da75126f4b247f428b1633552e1360b 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -1399,6 +1399,7 @@ void BrowserPluginGuest::OnSetSize(

if (auto_size_enabled_ && (!old_auto_size_enabled ||

(old_max_size != max_auto_size_) ||

(old_min_size != min_auto_size_))) {

+ RecordAction(UserMetricsAction("BrowserPlugin.Guest.EnableAutoResize"));

GetWebContents()->GetRenderViewHost()->EnableAutoResize(

min_auto_size_, max_auto_size_);

// TODO(fsamuel): If we're changing autosize parameters, then we force