Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 23691012: Renamed packaged_app to legacy_packaged_app in extension feature files. It's (Closed)

Created:
7 years, 3 months ago by not at google - send to devlin
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Renamed packaged_app to legacy_packaged_app in extension feature files. It's confusing otherwise since the C++ enum is called LEGACY_PACKAGED_APP. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220498

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix tostring message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -135 lines) Patch
M chrome/common/extensions/api/_api_features.json View 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 19 chunks +37 lines, -37 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 31 chunks +72 lines, -72 lines 0 comments Download
M chrome/common/extensions/features/base_feature_provider_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/features/complex_feature_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/common/extensions/features/simple_feature.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/features/simple_feature_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
not at google - send to devlin
One of many pet peeves.
7 years, 3 months ago (2013-08-29 20:43:58 UTC) #1
asargent_no_longer_on_chrome
looks like you have a couple of legitimate test failures to fix, e.g. http://build.chromium.org/p/tryserver.chromium/builders/linux_aura/builds/72989 I ...
7 years, 3 months ago (2013-08-29 22:06:03 UTC) #2
not at google - send to devlin
fixed
7 years, 3 months ago (2013-08-29 23:04:28 UTC) #3
asargent_no_longer_on_chrome
lgtm! https://codereview.chromium.org/23691012/diff/1/chrome/common/extensions/features/simple_feature.cc File chrome/common/extensions/features/simple_feature.cc (right): https://codereview.chromium.org/23691012/diff/1/chrome/common/extensions/features/simple_feature.cc#newcode166 chrome/common/extensions/features/simple_feature.cc:166: return "legacy packaged app"; wow, this was totally ...
7 years, 3 months ago (2013-08-29 23:45:58 UTC) #4
not at google - send to devlin
https://codereview.chromium.org/23691012/diff/1/chrome/common/extensions/features/simple_feature.cc File chrome/common/extensions/features/simple_feature.cc (right): https://codereview.chromium.org/23691012/diff/1/chrome/common/extensions/features/simple_feature.cc#newcode166 chrome/common/extensions/features/simple_feature.cc:166: return "legacy packaged app"; On 2013/08/29 23:45:59, Antony Sargent ...
7 years, 3 months ago (2013-08-29 23:48:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/23691012/25001
7 years, 3 months ago (2013-08-29 23:48:55 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 03:37:31 UTC) #7
Message was sent while issue was closed.
Change committed as 220498

Powered by Google App Engine
This is Rietveld 408576698