Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/common/extensions/features/complex_feature_unittest.cc

Issue 23691012: Renamed packaged_app to legacy_packaged_app in extension feature files. It's (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tostring message Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/features/complex_feature.h" 5 #include "chrome/common/extensions/features/complex_feature.h"
6 6
7 #include "chrome/common/extensions/features/feature_channel.h" 7 #include "chrome/common/extensions/features/feature_channel.h"
8 #include "chrome/common/extensions/features/simple_feature.h" 8 #include "chrome/common/extensions/features/simple_feature.h"
9 #include "chrome/common/extensions/value_builder.h" 9 #include "chrome/common/extensions/value_builder.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 23 matching lines...) Expand all
34 const std::string kIdFoo("fooabbbbccccddddeeeeffffgggghhhh"); 34 const std::string kIdFoo("fooabbbbccccddddeeeeffffgggghhhh");
35 const std::string kIdBar("barabbbbccccddddeeeeffffgggghhhh"); 35 const std::string kIdBar("barabbbbccccddddeeeeffffgggghhhh");
36 scoped_ptr<ComplexFeature::FeatureList> features( 36 scoped_ptr<ComplexFeature::FeatureList> features(
37 new ComplexFeature::FeatureList()); 37 new ComplexFeature::FeatureList());
38 38
39 // Rule: "extension", whitelist "foo". 39 // Rule: "extension", whitelist "foo".
40 scoped_ptr<SimpleFeature> simple_feature(new SimpleFeature()); 40 scoped_ptr<SimpleFeature> simple_feature(new SimpleFeature());
41 scoped_ptr<base::DictionaryValue> rule( 41 scoped_ptr<base::DictionaryValue> rule(
42 DictionaryBuilder() 42 DictionaryBuilder()
43 .Set("whitelist", ListBuilder().Append(kIdFoo)) 43 .Set("whitelist", ListBuilder().Append(kIdFoo))
44 .Set("extension_types", ListBuilder().Append("extension")).Build()); 44 .Set("extension_types", ListBuilder()
45 .Append("extension")).Build());
45 simple_feature->Parse(rule.get()); 46 simple_feature->Parse(rule.get());
46 features->push_back(simple_feature.release()); 47 features->push_back(simple_feature.release());
47 48
48 // Rule: "packaged_app", whitelist "bar". 49 // Rule: "legacy_packaged_app", whitelist "bar".
49 simple_feature.reset(new SimpleFeature()); 50 simple_feature.reset(new SimpleFeature());
50 rule = DictionaryBuilder() 51 rule = DictionaryBuilder()
51 .Set("whitelist", ListBuilder().Append(kIdBar)) 52 .Set("whitelist", ListBuilder().Append(kIdBar))
52 .Set("extension_types", ListBuilder().Append("packaged_app")).Build(); 53 .Set("extension_types", ListBuilder()
54 .Append("legacy_packaged_app")).Build();
53 simple_feature->Parse(rule.get()); 55 simple_feature->Parse(rule.get());
54 features->push_back(simple_feature.release()); 56 features->push_back(simple_feature.release());
55 57
56 scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass())); 58 scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
57 59
58 // Test match 1st rule. 60 // Test match 1st rule.
59 EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest( 61 EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
60 kIdFoo, 62 kIdFoo,
61 Manifest::TYPE_EXTENSION, 63 Manifest::TYPE_EXTENSION,
62 Feature::UNSPECIFIED_LOCATION, 64 Feature::UNSPECIFIED_LOCATION,
(...skipping 28 matching lines...) Expand all
91 93
92 // Rule: "extension", channel trunk. 94 // Rule: "extension", channel trunk.
93 scoped_ptr<SimpleFeature> simple_feature(new SimpleFeature()); 95 scoped_ptr<SimpleFeature> simple_feature(new SimpleFeature());
94 scoped_ptr<base::DictionaryValue> rule( 96 scoped_ptr<base::DictionaryValue> rule(
95 DictionaryBuilder() 97 DictionaryBuilder()
96 .Set("channel", "trunk") 98 .Set("channel", "trunk")
97 .Set("extension_types", ListBuilder().Append("extension")).Build()); 99 .Set("extension_types", ListBuilder().Append("extension")).Build());
98 simple_feature->Parse(rule.get()); 100 simple_feature->Parse(rule.get());
99 features->push_back(simple_feature.release()); 101 features->push_back(simple_feature.release());
100 102
101 // Rule: "packaged_app", channel stable. 103 // Rule: "legacy_packaged_app", channel stable.
102 simple_feature.reset(new SimpleFeature()); 104 simple_feature.reset(new SimpleFeature());
103 rule = DictionaryBuilder() 105 rule = DictionaryBuilder()
104 .Set("channel", "stable") 106 .Set("channel", "stable")
105 .Set("extension_types", ListBuilder().Append("packaged_app")).Build(); 107 .Set("extension_types", ListBuilder()
108 .Append("legacy_packaged_app")).Build();
106 simple_feature->Parse(rule.get()); 109 simple_feature->Parse(rule.get());
107 features->push_back(simple_feature.release()); 110 features->push_back(simple_feature.release());
108 111
109 scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass())); 112 scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
110 113
111 // Test match 1st rule. 114 // Test match 1st rule.
112 { 115 {
113 ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_UNKNOWN); 116 ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_UNKNOWN);
114 EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest( 117 EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
115 "1", 118 "1",
(...skipping 20 matching lines...) Expand all
136 EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest( 139 EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
137 "1", 140 "1",
138 Manifest::TYPE_EXTENSION, 141 Manifest::TYPE_EXTENSION,
139 Feature::UNSPECIFIED_LOCATION, 142 Feature::UNSPECIFIED_LOCATION,
140 Feature::UNSPECIFIED_PLATFORM, 143 Feature::UNSPECIFIED_PLATFORM,
141 Feature::GetCurrentPlatform()).result()); 144 Feature::GetCurrentPlatform()).result());
142 } 145 }
143 } 146 }
144 147
145 } // namespace 148 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698