Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 23686018: Fix a memory leak in chrome://version handler. (Closed)

Created:
7 years, 3 months ago by Alexei Svitkine (slow)
Modified:
7 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a memory leak in chrome://version handler. Found by the Mac OS X 'leaks' tool; fixed on a plane. BUG=292905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/ui/webui/version_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexei Svitkine (slow)
7 years, 3 months ago (2013-09-16 20:55:15 UTC) #1
Evan Stade
lgtm
7 years, 3 months ago (2013-09-16 23:17:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23686018/1
7 years, 3 months ago (2013-09-16 23:22:36 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 23:33:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23686018/1
7 years, 3 months ago (2013-09-16 23:45:01 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 23:48:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23686018/1
7 years, 3 months ago (2013-09-16 23:52:21 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 06:48:56 UTC) #8
Message was sent while issue was closed.
Change committed as 223554

Powered by Google App Engine
This is Rietveld 408576698