Fix a memory leak in chrome://version handler.

chrome/browser/ui/webui/version_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/version_handler.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 67 matching lines @@
       content::BrowserThread::FILE, FROM_HERE,
           base::Bind(&GetFilePaths, Profile::FromWebUI(web_ui())->GetPath(),
                      base::Unretained(exec_path_buffer),
                      base::Unretained(profile_path_buffer)),
           base::Bind(&VersionHandler::OnGotFilePaths,
                      weak_ptr_factory_.GetWeakPtr(),
                      base::Owned(exec_path_buffer),
                      base::Owned(profile_path_buffer)));
 
   // Respond with the variations info immediately.
-  scoped_ptr<ListValue> variations_list(new ListValue());
   std::vector<std::string> variations;
 #if !defined(NDEBUG)
   base::FieldTrial::ActiveGroups active_groups;
   base::FieldTrialList::GetActiveFieldTrialGroups(&active_groups);
 
   const unsigned char kNonBreakingHyphenUTF8[] = { 0xE2, 0x80, 0x91, '\0' };
   const std::string kNonBreakingHyphenUTF8String(
       reinterpret_cast<const char*>(kNonBreakingHyphenUTF8));
   for (size_t i = 0; i < active_groups.size(); ++i) {
     std::string line = active_groups[i].trial_name + ":" +
                        active_groups[i].group_name;
     ReplaceChars(line, "-", kNonBreakingHyphenUTF8String, &line);
     variations.push_back(line);
   }
 #else
   // In release mode, display the hashes only.
   std::vector<string16> active_groups;
   chrome_variations::GetFieldTrialActiveGroupIdsAsStrings(&active_groups);
   for (size_t i = 0; i < active_groups.size(); ++i)
     variations.push_back(UTF16ToASCII(active_groups[i]));
 #endif
 
+  ListValue variations_list;
   for (std::vector<std::string>::const_iterator it = variations.begin();
       it != variations.end(); ++it) {
-    variations_list->Append(Value::CreateStringValue(*it));
+    variations_list.Append(Value::CreateStringValue(*it));
   }
 
   // In release mode, this will return an empty list to clear the section.
-  web_ui()->CallJavascriptFunction("returnVariationInfo",
-                                   *variations_list.release());
+  web_ui()->CallJavascriptFunction("returnVariationInfo", variations_list);
 }
 
 void VersionHandler::OnGotFilePaths(string16* executable_path_data,
                                     string16* profile_path_data) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   StringValue exec_path(*executable_path_data);
   StringValue profile_path(*profile_path_data);
   web_ui()->CallJavascriptFunction("returnFilePaths", exec_path, profile_path);
 }
@@ skipping 15 matching lines @@
         flash_version = info_array[i].version;
         break;
       }
     }
   }
 
   StringValue arg(flash_version);
   web_ui()->CallJavascriptFunction("returnFlashVersion", arg);
 }
 #endif  // defined(ENABLE_PLUGINS)