Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 23660006: FeatureInfo: Remove allowed_extensions and init workarounds early (Closed)

Created:
7 years, 3 months ago by no sievers
Modified:
7 years, 3 months ago
Reviewers:
palmer, Zhenyao Mo, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

FeatureInfo: Remove allowed_extensions and init workarounds early This removes passing allowed_extensions all the way through, since it was ignored anyways. It also initializes the workarounds from the commandline during FeatureInfo construction so it can be used to make decisions before the first context is created and initialized. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221438

Patch Set 1 #

Patch Set 2 : fix android_webview build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -174 lines) Patch
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 2 chunks +3 lines, -6 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 7 chunks +6 lines, -17 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_context_3d.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.h View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 7 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/context_group.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 2 chunks +8 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +21 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 38 chunks +25 lines, -53 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
no sievers
I'd like to make virtual contexts a proper workaround flag on Android, and for that ...
7 years, 3 months ago (2013-09-04 22:07:42 UTC) #1
no sievers
On 2013/09/04 22:07:42, sievers wrote: > I'd like to make virtual contexts a proper workaround ...
7 years, 3 months ago (2013-09-04 22:11:45 UTC) #2
piman
LGTM, nice cleanup.
7 years, 3 months ago (2013-09-04 22:22:34 UTC) #3
no sievers
+palmer for removal of field in content/common/gpu/gpu_messages.h
7 years, 3 months ago (2013-09-04 23:47:29 UTC) #4
Zhenyao Mo
LGTM
7 years, 3 months ago (2013-09-05 00:05:18 UTC) #5
palmer
lgtm
7 years, 3 months ago (2013-09-05 00:20:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/23660006/7001
7 years, 3 months ago (2013-09-05 00:24:55 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82901
7 years, 3 months ago (2013-09-05 01:59:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/23660006/7001
7 years, 3 months ago (2013-09-05 04:23:14 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83029
7 years, 3 months ago (2013-09-05 05:19:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/23660006/7001
7 years, 3 months ago (2013-09-05 15:34:26 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 15:41:25 UTC) #12
Message was sent while issue was closed.
Change committed as 221438

Powered by Google App Engine
This is Rietveld 408576698