Issue 11791032: Refactor FeatureInfo so you can't request features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11791032: Refactor FeatureInfo so you can't request features. (Closed)

Created:
7 years, 11 months ago by greggman

Modified:
7 years, 11 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor FeatureInfo so you can't request features. With this change all contexts should share the same features. Another CL can try to make it so there is only one global instance of a FeatureInfo. BUG=168628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175473

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -196 lines)			Patch
M	gpu/command_buffer/service/feature_info.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/feature_info.cc	View	16 chunks	+78 lines, -151 lines	0 comments	Download
M	gpu/command_buffer/service/feature_info_unittest.cc	View	4 chunks	+0 lines, -10 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	4 chunks	+14 lines, -31 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11791032/1

7 years, 11 months ago (2013-01-07 21:04:24 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_aura for step(s) interactive_ui_tests

7 years, 11 months ago (2013-01-07 23:27:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11791032/1

7 years, 11 months ago (2013-01-07 23:51:57 UTC) #5

Message was sent while issue was closed.

Change committed as 175473

Expand Messages | Collapse Messages