Ensure class mirrors on non-generic classes always have their runtime type set.

Ensure class mirrors on non-generic classes always have their runtime type set. Add a test for class mirror equality.

BUG=http://dartbug.com/12800
R=ahe@google.com, asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26951

[siva, 2013-08-28 23:12:06]

LGTM but please wait for an LGTM from Ahe for the test case.

https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors.cc#new...
runtime/lib/mirrors.cc:304: ASSERT(!(cls.NumTypeParameters() == 0) ||
!type.IsNull());
The comment here is very cryptic, you probably should elaborate here
that the assertion is to ensure this function is called with a
non null runtime 'type' parameter for a non generic 'cls' parameter.

https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors_impl.d...
runtime/lib/mirrors_impl.dart:286: // TODO(rmacnak): Use the reflectee's
identity hash.
Please open an issue for this and use the issue number in the TODO.

[rmacnak, 2013-08-29 17:32:39]

On 2013/08/28 23:12:06, siva wrote:
> LGTM but please wait for an LGTM from Ahe for the test case.
> 
> https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors.cc
> File runtime/lib/mirrors.cc (right):
> 
>
https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors.cc#new...
> runtime/lib/mirrors.cc:304: ASSERT(!(cls.NumTypeParameters() == 0) ||
> !type.IsNull());
> The comment here is very cryptic, you probably should elaborate here
> that the assertion is to ensure this function is called with a
> non null runtime 'type' parameter for a non generic 'cls' parameter.

Done.

>
https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors_impl.dart
> File runtime/lib/mirrors_impl.dart (right):
> 
>
https://codereview.chromium.org/23657002/diff/5001/runtime/lib/mirrors_impl.d...
> runtime/lib/mirrors_impl.dart:286: // TODO(rmacnak): Use the reflectee's
> identity hash.
> Please open an issue for this and use the issue number in the TODO.

Done.

[ahe, 2013-08-30 21:49:29]

lgtm

[rmacnak, 2013-08-30 21:51:38]

Committed patchset #5 manually as r26951 (presubmit successful).