Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: tests/lib/mirrors/libraries_test.dart

Issue 23657002: Ensure class mirrors on non-generic classes always have their runtime type set. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase, expand equality coverage Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/equality_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/libraries_test.dart
diff --git a/tests/lib/mirrors/libraries_test.dart b/tests/lib/mirrors/libraries_test.dart
index 70a5e5890479faffdba4eb6d5f92bfdfd4e183fa..6639083241f713d29af7e8bc0b193831e3d86005 100644
--- a/tests/lib/mirrors/libraries_test.dart
+++ b/tests/lib/mirrors/libraries_test.dart
@@ -18,12 +18,9 @@ main() {
LibraryMirror mirrorsLibrary = libraries[Uri.parse('dart:mirrors')];
Expect.isNotNull(mirrorsLibrary, 'mirrorsLibrary is null');
- print(mirrorsLibrary.classes);
ClassMirror cls = mirrorsLibrary.classes[const Symbol('LibraryMirror')];
Expect.isNotNull(cls, 'cls is null');
Expect.equals(const Symbol('dart.mirrors.LibraryMirror'), cls.qualifiedName);
- // TODO(ahe): Enable when VM implements equality of class mirrors:
- // Expect.equals(reflectClass(LibraryMirror), cls);
- print(mirrorsLibrary);
+ Expect.equals(reflectClass(LibraryMirror), cls);
}
« no previous file with comments | « tests/lib/mirrors/equality_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698