Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 23654010: Component Installer provides proper version to traits on registration. (Closed)

Created:
7 years, 3 months ago by waffles
Modified:
7 years, 3 months ago
CC:
chromium-reviews, xhwang, Sorin Jianu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Component Installer provides proper version to traits on registration. Looks like it was originally a copy/paste error. BUG=284895 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221494

Patch Set 1 #

Patch Set 2 : Uploaded the wrong fix, here we go. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/component_updater/default_component_installer.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
waffles
Hello cpu@, Please take a look at this 2-line bug fix for the DefaultComponentInstaller. Thanks!
7 years, 3 months ago (2013-09-04 20:48:32 UTC) #1
xhwang
lgtm, thanks!
7 years, 3 months ago (2013-09-04 20:51:55 UTC) #2
xhwang
Can we get this in soon? Thanks!
7 years, 3 months ago (2013-09-05 01:10:31 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
7 years, 3 months ago (2013-09-05 17:16:26 UTC) #4
cpu_(ooo_6.6-7.5)
btw looks like we need a test here, in a different CL of course.
7 years, 3 months ago (2013-09-05 17:17:43 UTC) #5
waffles
On 2013/09/05 17:17:43, cpu wrote: > btw looks like we need a test here, in ...
7 years, 3 months ago (2013-09-05 17:39:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/waffles@chromium.org/23654010/6001
7 years, 3 months ago (2013-09-05 17:41:16 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 19:35:17 UTC) #8
Message was sent while issue was closed.
Change committed as 221494

Powered by Google App Engine
This is Rietveld 408576698