Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: chrome/browser/component_updater/default_component_installer.cc

Issue 23654010: Component Installer provides proper version to traits on registration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Uploaded the wrong fix, here we go. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/default_component_installer.cc
diff --git a/chrome/browser/component_updater/default_component_installer.cc b/chrome/browser/component_updater/default_component_installer.cc
index 56bede1d827a6864d6c71407c5cf67f368fcd0ac..9c7e6e02eda5dd2293b9ef0ba3d335d27f1a5928 100644
--- a/chrome/browser/component_updater/default_component_installer.cc
+++ b/chrome/browser/component_updater/default_component_installer.cc
@@ -161,13 +161,12 @@ void DefaultComponentInstaller::FinishRegistration(
return;
}
- base::Version installed_version;
- if (current_version_.CompareTo(base::Version(kNullVersion)) <= 0) {
+ if (current_version_.CompareTo(base::Version(kNullVersion)) > 0) {
content::BrowserThread::PostTask(
content::BrowserThread::FILE, FROM_HERE,
base::Bind(&ComponentInstallerTraits::ComponentReady,
base::Unretained(installer_traits_.get()),
- installed_version,
+ current_version_,
GetInstallDirectory()));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698