Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm

Issue 23653052: [rAc] Fetch username concurrently with fetching Wallet items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm
index d5718926aaf0dba33f8d0a55963c409ab1171807..d831d69f4ce2c0057cffab3e8e303a763e767f93 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm
@@ -109,7 +109,7 @@ SkColor kSubtleBorderColor = 0xffdfdfdf;
CGFloat y = NSMaxY([self bounds]) - autofill::kArrowHeight -
kOverlayTextInterlineSpacing;
for (NSTextView* label in [self subviews]) {
- DCHECK([label isKindOfClass:[NSTextView class]]);
+ //DCHECK([label isKindOfClass:[NSTextView class]]);
Ilya Sherman 2013/09/20 06:49:56 Augh, please ignore this diff. Btw, this DCHECK c
groby-ooo-7-16 2013/09/20 16:07:13 That is not good, because we _expect_ it to be an
groby-ooo-7-16 2013/09/20 16:10:19 And by "created as labels" I mean created as NSTex
CGFloat labelHeight = NSHeight([label frame]);
[label setFrame:NSMakeRect(0, y - labelHeight,
NSWidth([self bounds]), labelHeight)];
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698