[rAc] Fetch username concurrently with fetching Wallet items.

chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
@@ skipping 91 matching lines @@
     [labels addObject:label];
   }
   [self setSubviews:labels];
   [self setHidden:([labels count] == 0)];
 }
 
 - (void)performLayout {
   CGFloat y = NSMaxY([self bounds]) - autofill::kArrowHeight -
       kOverlayTextInterlineSpacing;
   for (NSTextView* label in [self subviews]) {
-    DCHECK([label isKindOfClass:[NSTextView class]]);
+    //DCHECK([label isKindOfClass:[NSTextView class]]);

[Ilya Sherman, 2013/09/20 06:49:56]

Augh, please ignore this diff.  Btw, this DCHECK consistently fails in Wallet
mode :P

[groby-ooo-7-16, 2013/09/20 16:07:13]

That is not good, because we _expect_ it to be an NSTextView. Ugh.

And if you look at setMessages: all the subviews are created as labels.
On 2013/09/20 06:49:56, Ilya Sherman wrote:

[groby-ooo-7-16, 2013/09/20 16:10:19]

And by "created as labels" I mean created as NSTextView. I better get some
coffee :)

On 2013/09/20 16:07:13, groby wrote:

     CGFloat labelHeight = NSHeight([label frame]);
     [label setFrame:NSMakeRect(0, y - labelHeight,
                                NSWidth([self bounds]), labelHeight)];
     y = NSMinY([label frame]) - kOverlayTextInterlineSpacing;
   }
   DCHECK_GE(y, 0.0);
 }
 
 - (NSSize)preferredSize {
   NOTREACHED();
@@ skipping 80 matching lines @@
       NSMakeRect(0, 0, NSWidth(bounds), messageHeight)];
   [messageStackView_ performLayout];
 
   NSSize imageSize = [[imageView_ image] size];
   [imageView_ setFrame:NSMakeRect(
        0, NSMaxY([messageStackView_ frame]) + kOverlayImageBottomMargin,
        NSWidth(bounds), imageSize.height)];
 }
 
 @end