Issue 23653019: [telemetry] Don't require forwarder if we are using RNDIS on Android.

Issue 23653019: [telemetry] Don't require forwarder if we are using RNDIS on Android. (Closed)

Created:
7 years, 3 months ago by pauljensen

Modified:
7 years, 3 months ago

Reviewers:
szym, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Don't require forwarder if we are using RNDIS on Android. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221627

Patch Set 2 : Fix unittests #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tools/telemetry/telemetry/core/browser_options.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

szym

lgtm https://codereview.chromium.org/23653019/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py (right): https://codereview.chromium.org/23653019/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py#newcode183 tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:183: logging.warn(' ninja -C out/Release forwarder2 md5sum') AFAIU md5sum ...

7 years, 3 months ago (2013-09-05 18:03:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pauljensen@chromium.org/23653019/1

7 years, 3 months ago (2013-09-05 18:40:13 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=166027

7 years, 3 months ago (2013-09-05 20:11:46 UTC) #5

pauljensen

Tony, can you review my browser_options.py change? I'm just initializing the option value in cases ...

7 years, 3 months ago (2013-09-05 20:50:44 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pauljensen@chromium.org/23653019/29001

7 years, 3 months ago (2013-09-05 21:11:26 UTC) #8

Message was sent while issue was closed.

Change committed as 221627

Expand Messages | Collapse Messages