tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py - Issue 23653019: [telemetry] Don't require forwarder if we are using RNDIS on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

Issue 23653019: [telemetry] Don't require forwarder if we are using RNDIS on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unittests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

index c74af152f34bd83a58601e5a25617a435b8b61b9..2fba66527c32cd1180ccca59f5c490139ab36791 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

@@ -175,7 +175,8 @@ def FindAllAvailableBrowsers(finder_options, logging=real_logging):

# See if the "forwarder" is installed -- we need this to host content locally

# but make it accessible to the device.

- if len(possible_browsers) and not adb_commands.HasForwarder():

+ if (len(possible_browsers) and not finder_options.android_rndis and

+ not adb_commands.HasForwarder()):

logging.warn('telemetry detected an android device. However,')

logging.warn('Chrome\'s port-forwarder app is not available.')

logging.warn('To build:')

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/browser_options.py » ('j') | no next file with comments »