Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 23653002: Move ScopedPtrHashMap from cc to base (Closed)

Created:
7 years, 3 months ago by powei
Modified:
7 years, 3 months ago
Reviewers:
danakj, brettw, jam, Nico
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, jam, darin (slow to review)
Visibility:
Public.

Description

So that ScopedPtrHashMap can be used by user outside of cc. BUG=156199 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220488

Patch Set 1 #

Patch Set 2 : Moved to base/containers #

Total comments: 1

Patch Set 3 : jam's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -186 lines) Patch
M base/base.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A + base/containers/scoped_ptr_hash_map.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
D cc/base/scoped_ptr_hash_map.h View 1 chunk +0 lines, -157 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/test_web_graphics_context_3d.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/debug/test_web_graphics_context_3d.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/output/direct_renderer.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/output/direct_renderer.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M cc/quads/render_pass.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/layer_tiling_data.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/worker_pool.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/tree_synchronizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/tree_synchronizer.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/DEPS View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
powei
PTAL. Also, any preference over the directory? base/, base/memory/, or base/containers/? Other concerns? Thanks very ...
7 years, 3 months ago (2013-08-28 00:29:33 UTC) #1
danakj
This should go in base/containers/ like the other hash tables stuff.
7 years, 3 months ago (2013-08-28 00:32:22 UTC) #2
jam
content/DEPS lgtm, but i'm not an owner in base so you'll need to get a ...
7 years, 3 months ago (2013-08-28 15:49:36 UTC) #3
powei
On 2013/08/28 15:49:36, jam wrote: > content/DEPS lgtm, but i'm not an owner in base ...
7 years, 3 months ago (2013-08-28 16:02:09 UTC) #4
danakj
cc/ changes LGTM
7 years, 3 months ago (2013-08-28 17:30:02 UTC) #5
powei
darin is probably busy. Can you help take a look, thakis?
7 years, 3 months ago (2013-08-28 22:25:50 UTC) #6
Nico
+brettw (I think this makes sense, and if he doesn't reply, I'll stamp this as ...
7 years, 3 months ago (2013-08-28 23:04:25 UTC) #7
brettw
lgtm seems OK
7 years, 3 months ago (2013-08-29 21:10:04 UTC) #8
powei
On 2013/08/29 21:10:04, brettw wrote: > lgtm > > seems OK Great! Thanks everyone.
7 years, 3 months ago (2013-08-29 21:12:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/powei@chromium.org/23653002/2
7 years, 3 months ago (2013-08-29 21:16:38 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 02:41:34 UTC) #11
Message was sent while issue was closed.
Change committed as 220488

Powered by Google App Engine
This is Rietveld 408576698