Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/renderer/extensions/chrome_v8_context.h

Issue 23636015: Remove unsafe access hacks from ScopedPersistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review (jyasskin)' Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_v8_context.h
diff --git a/chrome/renderer/extensions/chrome_v8_context.h b/chrome/renderer/extensions/chrome_v8_context.h
index 8007bb2433f58a30303fe24634bc223c7e75b105..5e33b71da9bb363e7fa9289eb248743d2fa8b877 100644
--- a/chrome/renderer/extensions/chrome_v8_context.h
+++ b/chrome/renderer/extensions/chrome_v8_context.h
@@ -43,11 +43,11 @@ class ChromeV8Context : public RequestSender::Source {
// Returns true if this context is still valid, false if it isn't.
// A context becomes invalid via Invalidate().
bool is_valid() const {
- return !v8_context_.get().IsEmpty();
+ return !v8_context_.IsEmpty();
}
v8::Handle<v8::Context> v8_context() const {
- return v8_context_.get();
+ return v8_context_.NewHandle(v8::Isolate::GetCurrent());
}
const Extension* extension() const {

Powered by Google App Engine
This is Rietveld 408576698