chrome/renderer/extensions/chrome_v8_context.cc - Issue 23636015: Remove unsafe access hacks from ScopedPersistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 23636015: Remove unsafe access hacks from ScopedPersistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: code review (jyasskin)' Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/chrome_v8_context.cc

diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc

index c21ac02dea1b5820b656cdd89d6a4dea0b621cea..1e0ca6fa754ccdb226e86e4e2d4d242bab637054 100644

--- a/chrome/renderer/extensions/chrome_v8_context.cc

+++ b/chrome/renderer/extensions/chrome_v8_context.cc

@@ -143,7 +143,7 @@ void ChromeV8Context::OnResponseReceived(const std::string& name,

v8::Integer::New(request_id),

v8::String::New(name.c_str()),

v8::Boolean::New(success),

- converter->ToV8Value(&response, v8_context_.get()),

+ converter->ToV8Value(&response, v8_context_.NewHandle(isolate())),

v8::String::New(error.c_str())

};