gpu: Disable EXT_discard_framebuffer on ARM GPUs and expose it for pre-ES3

gpu: Disable EXT_discard_framebuffer on ARM GPUs and expose it for pre-ES3

Disable the EXT_discard_framebuffer extension on ARM GPUs (e.g., Nexus
10) as it is causing dropped frames and flickering.

This patch also exposes the EXT_discard_framebuffer extension on
pre-OpenGL ES 3.0 drivers which support it.

Tested on Nexus 10, Nexus 4 and Galaxy S4.

BUG=290876
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223338

[no sievers, 2013-09-13 23:02:25]

lgtm

[commit-bot: I haz the power, 2013-09-16 09:35:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/23629043/1

[commit-bot: I haz the power, 2013-09-16 09:35:59]

Failed to apply patch for gpu/config/gpu_driver_bug_list_json.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file gpu/config/gpu_driver_bug_list_json.cc
  Hunk #1 FAILED at 85.
  Hunk #2 succeeded at 605 with fuzz 2 (offset 11 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
gpu/config/gpu_driver_bug_list_json.cc.rej

Patch:       gpu/config/gpu_driver_bug_list_json.cc
Index: gpu/config/gpu_driver_bug_list_json.cc
diff --git a/gpu/config/gpu_driver_bug_list_json.cc
b/gpu/config/gpu_driver_bug_list_json.cc
index
79dc6c1e55c68be2a3efb93d2432d818df069f00..3fecb1a31a085a9abc4e586deeab306ebba5afd3
100644
--- a/gpu/config/gpu_driver_bug_list_json.cc
+++ b/gpu/config/gpu_driver_bug_list_json.cc
@@ -85,7 +85,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
 {
   "name": "gpu driver bug list",
   // Please update the version number whenever you change this file.
-  "version": "2.13",
+  "version": "2.14",
   "entries": [
     {
       "id": 1,
@@ -594,6 +594,21 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
       "features": [
         "use_virtualized_gl_contexts"
       ]
+    },
+    {
+      "id": 39,
+      "cr_bugs": [290876],
+      "description": "Framebuffer discarding causes flickering on ARM",
+      "os": {
+        "type": "android"
+      },
+      "gl_vendor": {
+        "op": "beginwith",
+        "value": "ARM"
+      },
+      "features": [
+        "disable_ext_discard_framebuffer"
+      ]
     }
   ]
 }

[commit-bot: I haz the power, 2013-09-16 09:52:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/23629043/8001

[commit-bot: I haz the power, 2013-09-16 13:16:57]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-16 13:26:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/23629043/8001

[commit-bot: I haz the power, 2013-09-16 14:24:40]

Change committed as 223338