Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2362673005:
[Android] Change default search engine setting page to full screen (Closed)
Description[Android] Change default search engine setting page to full screen
1. Change SearchEnginePreference from ListPrefrence to PrerenceFragment
to make it display in full screen.
2. Add layout and logic to confirm setting with SAVE button.
BUG=649443
Committed: https://crrev.com/c52954f443d7d0481755c584d3449dbb6143a253
Cr-Commit-Position: refs/heads/master@{#421882}
Patch Set 1 #
Total comments: 18
Patch Set 2 : update based on Ian's comments #Patch Set 3 : update bottom bar layout to match layout of mockup UI. #
Total comments: 12
Patch Set 4 : update search engine setting page bottom bar height. #Patch Set 5 : update based on Ian's new comments and Rolfe's suggestions for UI. #
Total comments: 12
Patch Set 6 : Update based on Ian's comments. #Patch Set 7 : fix the problem that when orientation is changed and in landscape, listview is larger than its view… #
Total comments: 10
Patch Set 8 : update based on Theresa's comments. #Patch Set 9 : Update to fix failures on PreferencesTest text cases. #Depends on Patchset: Messages
Total messages: 43 (21 generated)
The CQ bit was checked by ltian@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ltian@chromium.org changed reviewers: + ianwen@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
Looks good in general. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... File chrome/android/java/res/layout/custom_preference.xml (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/custom_preference.xml:10: android:layout_height="match_parent" How will this affect data saver and accessibility? I know these two features use this file as well. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:13: android:orientation="vertical"> Add space here https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:21: android:id="@+id/bottombar_shadow" You should have a top margin that is -4dp, so that the shadow can show upon the listview, without taking space. You should also upload a screenshot to the bug. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:25: android:scaleY="-1" /> Add spaced here. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:44: android:layout_gravity="center_vertical"/> Space here as well https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:56: android:layout_gravity="center_vertical"/> And here https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java:182: ChromeBasePreference searchEnginePref = How about creating a updateSummary() private method to include #182-#187. Then call this method in #111. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:19: * A custom preference fragment for selecting a default search engine. Remove "custom"? https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:46: mCancelButton = (Button) view.findViewById(R.id.cancel_button); You don't need to cast it to Button, as a normal view could also have a OnClickListener. I would cache these buttons just as views.
https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... File chrome/android/java/res/layout/custom_preference.xml (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/custom_preference.xml:10: android:layout_height="match_parent" On 2016/09/23 20:43:24, Ian Wen wrote: > How will this affect data saver and accessibility? I know these two features use > this file as well. Sorry I modified this part for debug before and forgot to change it back, wrap_content also work for SearchEnginePreference, so I just set it back as before. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:13: android:orientation="vertical"> On 2016/09/23 20:43:24, Ian Wen wrote: > Add space here Done. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:21: android:id="@+id/bottombar_shadow" On 2016/09/23 20:43:24, Ian Wen wrote: > You should have a top margin that is -4dp, so that the shadow can show upon the > listview, without taking space. > > You should also upload a screenshot to the bug. Done. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:25: android:scaleY="-1" /> On 2016/09/23 20:43:25, Ian Wen wrote: > Add spaced here. Done. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:44: android:layout_gravity="center_vertical"/> On 2016/09/23 20:43:24, Ian Wen wrote: > Space here as well Done. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/search_engine_layout.xml:56: android:layout_gravity="center_vertical"/> On 2016/09/23 20:43:25, Ian Wen wrote: > And here Done. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java:182: ChromeBasePreference searchEnginePref = On 2016/09/23 20:43:25, Ian Wen wrote: > How about creating a updateSummary() private method to include #182-#187. Then > call this method in #111. Done. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:19: * A custom preference fragment for selecting a default search engine. On 2016/09/23 20:43:25, Ian Wen wrote: > Remove "custom"? Done. https://codereview.chromium.org/2362673005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:46: mCancelButton = (Button) view.findViewById(R.id.cancel_button); On 2016/09/23 20:43:25, Ian Wen wrote: > You don't need to cast it to Button, as a normal view could also have a > OnClickListener. I would cache these buttons just as views. Done.
https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:15: android:id="@android:id/list" Indent size in XML files is 4. And it should be consistent throughout the entire file. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:29: android:layout_width="match_parent" Indent size wrong. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:30: android:layout_height="48dp" Per our discussion, change it to 56dp. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:37: android:id="@+id/cancel_button" Indent size wrong. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java (right): https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java:111: if (TemplateUrlService.getInstance().isLoaded()) { This code should live in SearchEnginePreferences, not in MainPreference. You could easily make SearchEnginePreferences as LoadListener. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:59: if (v.getId() == R.id.cancel_button) { Nit: Use v == mCancelButton and v == mSaveButton.
https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:15: android:id="@android:id/list" On 2016/09/23 23:00:19, Ian Wen wrote: > Indent size in XML files is 4. And it should be consistent throughout the entire > file. Done. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:29: android:layout_width="match_parent" On 2016/09/23 23:00:19, Ian Wen wrote: > Indent size wrong. Done. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:30: android:layout_height="48dp" On 2016/09/23 23:00:19, Ian Wen wrote: > Per our discussion, change it to 56dp. Done. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:37: android:id="@+id/cancel_button" On 2016/09/23 23:00:19, Ian Wen wrote: > Indent size wrong. Done. https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java (right): https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java:111: if (TemplateUrlService.getInstance().isLoaded()) { On 2016/09/23 23:00:19, Ian Wen wrote: > This code should live in SearchEnginePreferences, not in MainPreference. You > could easily make SearchEnginePreferences as LoadListener. SearchEnginePreferences now extends PreferenceFragment which is a Fragment. It does not have setSummary() to change summary of preference. Original class extends ListPreference which is a Preference, that class has setSummary(). https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:59: if (v.getId() == R.id.cancel_button) { On 2016/09/23 23:00:19, Ian Wen wrote: > Nit: Use v == mCancelButton and v == mSaveButton. Done.
https://chromiumcodereview.appspot.com/2362673005/diff/80001/chrome/android/j... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://chromiumcodereview.appspot.com/2362673005/diff/80001/chrome/android/j... chrome/android/java/res/layout/search_engine_layout.xml:24: android:layout_marginTop="-1dp" Remove #24. https://chromiumcodereview.appspot.com/2362673005/diff/80001/chrome/android/j... chrome/android/java/res/layout/search_engine_layout.xml:27: android:visibility="invisible" /> Switch to gone. https://chromiumcodereview.appspot.com/2362673005/diff/80001/chrome/android/j... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://chromiumcodereview.appspot.com/2362673005/diff/80001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:80: mSearchEngineAdapter.notifyDataSetChanged(); Remove #80. https://chromiumcodereview.appspot.com/2362673005/diff/80001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:84: if (mListView.getLastVisiblePosition() == mSearchEngineAdapter.getCount() - 1) { Add comment: Display the divider if the listview is longer than its viewport. https://chromiumcodereview.appspot.com/2362673005/diff/80001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:85: mDivider.setVisibility(View.INVISIBLE); To Gone.
https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/res... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:24: android:layout_marginTop="-1dp" On 2016/09/26 18:32:01, Ian Wen wrote: > Remove #24. Done. https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:27: android:visibility="invisible" /> On 2016/09/26 18:32:01, Ian Wen wrote: > Switch to gone. Done. https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:80: mSearchEngineAdapter.notifyDataSetChanged(); On 2016/09/26 18:32:01, Ian Wen wrote: > Remove #80. Done. https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:84: if (mListView.getLastVisiblePosition() == mSearchEngineAdapter.getCount() - 1) { On 2016/09/26 18:32:01, Ian Wen wrote: > Add comment: > > Display the divider if the listview is longer than its viewport. Done. https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:85: mDivider.setVisibility(View.INVISIBLE); On 2016/09/26 18:32:01, Ian Wen wrote: > To Gone. Done.
https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/res... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/res... chrome/android/java/res/layout/search_engine_layout.xml:27: android:visibility="invisible" /> On 2016/09/26 18:46:44, ltian wrote: > On 2016/09/26 18:32:01, Ian Wen wrote: > > Switch to gone. > > Done. It seems after changing to "gone", when orientation is changed and in landscape layout, listview is larger than its viewport while in portrait layout, it is not, the divider is not displayed correctly. https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:85: mDivider.setVisibility(View.INVISIBLE); On 2016/09/26 18:46:44, ltian wrote: > On 2016/09/26 18:32:01, Ian Wen wrote: > > To Gone. > > Done. Same issue for "View.GONE" as it is in search_engine_layout.xml.
ltian@chromium.org changed reviewers: + twellington@chromium.org
twellington@chromium.org: Please review changes related to Preferences changes. Thanks!
lgtm. Segue to twellington. https://chromiumcodereview.appspot.com/2362673005/diff/120001/chrome/android/... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://chromiumcodereview.appspot.com/2362673005/diff/120001/chrome/android/... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:78: * Display the divider if the listview is longer than its viewport. s/Display/Displays
Looks good overall, just some nits and questions https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/re... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/re... chrome/android/java/res/layout/search_engine_layout.xml:25: android:scaleY="-1" Since this 1dp divider, should the background be a solid color? If so, scaleY="-1" is not necessary. If not, then calling it the "bottom_shadow" or "bottom_scrim" may be more appropriate than "bottombar_divider". https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:21: public class SearchEnginePreferences extends PreferenceFragment I think SearchEnginePreference makes more sense since there's only one preference that gets set (a single search engine choice). The only classes that are named plural "Preferences" control multiple preferences e.g. AccessibilityPreferences controls text scaling and force enable zoom. https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:24: static final String PREF_SEARCH_ENGINE = "search_engine"; Can this class use the public static in MainPreferences.java rather than declaring a new variable? https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:78: * Display the divider if the listview is longer than its viewport. nit: s/listview/ListView
https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/re... File chrome/android/java/res/layout/search_engine_layout.xml (right): https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/re... chrome/android/java/res/layout/search_engine_layout.xml:25: android:scaleY="-1" On 2016/09/27 18:02:13, Theresa Wellington wrote: > Since this 1dp divider, should the background be a solid color? If so, > scaleY="-1" is not necessary. If not, then calling it the "bottom_shadow" or > "bottom_scrim" may be more appropriate than "bottombar_divider". It's a shadow with only 1dp height, so I guess I should change its id to "bottom_shadow" for a clear definition. https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java (right): https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:21: public class SearchEnginePreferences extends PreferenceFragment On 2016/09/27 18:02:13, Theresa Wellington wrote: > I think SearchEnginePreference makes more sense since there's only one > preference that gets set (a single search engine choice). The only classes that > are named plural "Preferences" control multiple preferences e.g. > AccessibilityPreferences controls text scaling and force enable zoom. Done. https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:24: static final String PREF_SEARCH_ENGINE = "search_engine"; On 2016/09/27 18:02:13, Theresa Wellington wrote: > Can this class use the public static in MainPreferences.java rather than > declaring a new variable? Done. https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:78: * Display the divider if the listview is longer than its viewport. On 2016/09/27 18:02:13, Theresa Wellington wrote: > nit: s/listview/ListView Done. https://codereview.chromium.org/2362673005/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreferences.java:78: * Display the divider if the listview is longer than its viewport. On 2016/09/26 23:09:37, Ian Wen wrote: > s/Display/Displays Done.
lgtm
ltian@chromium.org changed reviewers: + tedchoc@chromium.org
tedchoc@chromium.org: Please review changes in GeolocationSnackbarController. Thanks!
On 2016/09/28 00:36:27, ltian wrote: > mailto:tedchoc@chromium.org: Please review changes in GeolocationSnackbarController. > > Thanks! GeolocationSnackbarController.java - lgtm
The CQ bit was checked by ltian@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org Link to the patchset: https://codereview.chromium.org/2362673005/#ps140001 (title: "update based on Theresa's comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by ltian@chromium.org to run a CQ dry run
The CQ bit was unchecked by ltian@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ltian@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ltian@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org, ianwen@chromium.org, twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2362673005/#ps160001 (title: "Update to fix failures on PreferencesTest text cases.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== [Android] Change default search engine setting page to full screen 1. Change SearchEnginePreference from ListPrefrence to PrerenceFragment to make it display in full screen. 2. Add layout and logic to confirm setting with SAVE button. BUG=649443 ========== to ========== [Android] Change default search engine setting page to full screen 1. Change SearchEnginePreference from ListPrefrence to PrerenceFragment to make it display in full screen. 2. Add layout and logic to confirm setting with SAVE button. BUG=649443 Committed: https://crrev.com/c52954f443d7d0481755c584d3449dbb6143a253 Cr-Commit-Position: refs/heads/master@{#421882} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/c52954f443d7d0481755c584d3449dbb6143a253 Cr-Commit-Position: refs/heads/master@{#421882}
Message was sent while issue was closed.
Patchset #10 (id:180001) has been deleted |
