Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 23623012: Move TextResourceDecoder from loader/ to fetch/ (Closed)

Created:
7 years, 3 months ago by Hajime Morrita
Modified:
7 years, 3 months ago
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, kinuko, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, aandrey+blink_chromium.org, kenneth.christiansen, gavinp+loader_chromium.org
Visibility:
Public.

Description

Move TextResourceDecoder from loader/ to fetch/ TextResourceDecoder is used by many classes including one from fetch/ and it is not tied to page navigation which loader/ is responsible for. BUG=280939 R=japhet,abarth TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -878 lines) Patch
M Source/core/core.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/DocumentResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ShaderResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/fetch/TextResourceDecoder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/fetch/TextResourceDecoder.cpp View 13 chunks +71 lines, -64 lines 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBaseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/inspector/NetworkResourcesData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/NetworkResourcesData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/loader/TextResourceDecoder.h View 1 chunk +0 lines, -105 lines 0 comments Download
D Source/core/loader/TextResourceDecoder.cpp View 1 chunk +0 lines, -683 lines 0 comments Download
M Source/core/loader/TextResourceDecoderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
PTAL?
7 years, 3 months ago (2013-08-30 07:16:16 UTC) #1
abarth-chromium
LGTM I'm not sure I fully understand TextResourceDecoder role's in the world. It seems like ...
7 years, 3 months ago (2013-08-30 07:19:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/23623012/1
7 years, 3 months ago (2013-08-30 09:16:11 UTC) #3
gmorrita
On 2013/08/30 07:19:44, abarth wrote: > LGTM > > I'm not sure I fully understand ...
7 years, 3 months ago (2013-08-30 09:17:02 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 10:33:01 UTC) #5
Message was sent while issue was closed.
Change committed as 156978

Powered by Google App Engine
This is Rietveld 408576698