Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 23619021: wpr_mode, no_proxy_server and browser_user_agent_type to BrowserOptions (Closed)

Created:
7 years, 3 months ago by achuithb
Modified:
7 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

wpr_mode, no_proxy_server and browser_user_agent_type to BrowserOptions These are used by chrome_browser_backend. BUG=269131 TEST=trybot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M tools/telemetry/telemetry/core/backends/browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 3 chunks +4 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/user_agent_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 5 chunks +14 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
achuithb
Tony, Dave, please take a look at this.
7 years, 3 months ago (2013-09-07 03:12:26 UTC) #1
tonyg
lgtm
7 years, 3 months ago (2013-09-07 17:19:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23619021/1
7 years, 3 months ago (2013-09-09 20:03:53 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 22:58:47 UTC) #4
Message was sent while issue was closed.
Change committed as 222122

Powered by Google App Engine
This is Rietveld 408576698