Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 23619021: wpr_mode, no_proxy_server and browser_user_agent_type to BrowserOptions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
index 218601394454a27e3a0ae1f05c5092fc2eb6abd7..f58726ed725ebe7bb040a983c9248631d6c6e2fa 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
@@ -79,13 +79,13 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
args.append('--metrics-recording-only')
args.append('--no-first-run')
args.append('--no-proxy-server')
- if self.finder_options.wpr_mode != wpr_modes.WPR_OFF:
+ if self.browser_options.wpr_mode != wpr_modes.WPR_OFF:
args.extend(wpr_server.GetChromeFlags(
self.WEBPAGEREPLAY_HOST,
self.webpagereplay_remote_http_port,
self.webpagereplay_remote_https_port))
args.extend(user_agent.GetChromeUserAgentArgumentFromType(
- self.finder_options.browser_user_agent_type))
+ self.browser_options.browser_user_agent_type))
extensions = [extension.local_path for extension in
self.finder_options.extensions_to_load
@@ -101,7 +101,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
if len(component_extensions) > 0:
args.append('--load-component-extension=%s' % component_extension_str)
- if self.finder_options.no_proxy_server:
+ if self.browser_options.no_proxy_server:
args.append('--no-proxy-server')
return args
« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698