Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: sandbox/linux/services/broker_process_unittest.cc

Issue 23619009: Do not use O_CLOEXEC for open() in the broker process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/services/broker_process.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/services/broker_process_unittest.cc
diff --git a/sandbox/linux/services/broker_process_unittest.cc b/sandbox/linux/services/broker_process_unittest.cc
index c0393ed2f50bac2dcacbbdd6f30f64e2014a9086..8ff4e00c8eca585f6d0ffcbeea78184f6261cdfb 100644
--- a/sandbox/linux/services/broker_process_unittest.cc
+++ b/sandbox/linux/services/broker_process_unittest.cc
@@ -405,14 +405,6 @@ void TestOpenComplexFlags(bool fast_check_in_client) {
// Important: use F_GETFD, not F_GETFL. The O_CLOEXEC flag in F_GETFL
// is actually not used by the kernel.
ASSERT_TRUE(FD_CLOEXEC & ret);
-
- // There is buggy userland code that can check for O_CLOEXEC with fcntl(2)
- // even though it doesn't mean anything. We need to support this case.
- // See crbug.com/237283.
- ret = fcntl(fd, F_GETFL);
- ASSERT_NE(-1, ret);
- ASSERT_TRUE(O_CLOEXEC & ret);
-
ASSERT_EQ(0, close(fd));
fd = open_broker.Open(kCpuInfo, O_RDONLY | O_NONBLOCK);
« no previous file with comments | « sandbox/linux/services/broker_process.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698