Do not use O_CLOEXEC for open() in the broker process.

sandbox/linux/services/broker_process_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/linux/services/broker_process.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <sys/types.h>
@@ skipping 387 matching lines @@
   ASSERT_EQ(0, ret & (O_CLOEXEC | O_NONBLOCK));
   ASSERT_EQ(0, close(fd));
 
   fd = open_broker.Open(kCpuInfo, O_RDONLY | O_CLOEXEC);
   ASSERT_GE(fd, 0);
   ret = fcntl(fd, F_GETFD);
   ASSERT_NE(-1, ret);
   // Important: use F_GETFD, not F_GETFL. The O_CLOEXEC flag in F_GETFL
   // is actually not used by the kernel.
   ASSERT_TRUE(FD_CLOEXEC & ret);
-
-  // There is buggy userland code that can check for O_CLOEXEC with fcntl(2)
-  // even though it doesn't mean anything. We need to support this case.
-  // See crbug.com/237283.
-  ret = fcntl(fd, F_GETFL);
-  ASSERT_NE(-1, ret);
-  ASSERT_TRUE(O_CLOEXEC & ret);
-
   ASSERT_EQ(0, close(fd));
 
   fd = open_broker.Open(kCpuInfo, O_RDONLY | O_NONBLOCK);
   ASSERT_GE(fd, 0);
   ret = fcntl(fd, F_GETFL);
   ASSERT_NE(-1, ret);
   ASSERT_TRUE(O_NONBLOCK & ret);
   ASSERT_EQ(0, close(fd));
 }
 
 TEST(BrokerProcess, OpenComplexFlagsWithClientCheck) {
   TestOpenComplexFlags(true /* fast_check_in_client */);
   // Don't do anything here, so that ASSERT works in the subfunction as
   // expected.
 }
 
 TEST(BrokerProcess, OpenComplexFlagsNoClientCheck) {
   TestOpenComplexFlags(false /* fast_check_in_client */);
   // Don't do anything here, so that ASSERT works in the subfunction as
   // expected.
 }
 
 }  // namespace sandbox