Issue 23619009: Do not use O_CLOEXEC for open() in the broker process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23619009: Do not use O_CLOEXEC for open() in the broker process. (Closed)

Created:
7 years, 3 months ago by Jorge Lucangeli Obes

Modified:
7 years, 3 months ago

Reviewers:
jln (very slow on Chromium)

CC:
chromium-reviews, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not use O_CLOEXEC for open() in the broker process. BUG=279503 TEST=sandbox_linux_unittests passes on Precise. TEST=sandbox_linux_unittests passes on daisy_spring w/ kernel 3.8 TEST=daisy_spring boots, sandbox is on, GPU accel works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220504

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -19 lines)			Patch
	M	sandbox/linux/services/broker_process.cc	View		4 chunks	+4 lines, -11 lines	0 comments	Download
	M	sandbox/linux/services/broker_process_unittest.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/23619009/1

7 years, 3 months ago (2013-08-29 22:01:48 UTC) #3

Message was sent while issue was closed.

Change committed as 220504

Expand Messages | Collapse Messages