Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23608003: Default keyboard layout should be set considering owners preference. (Closed)

Created:
7 years, 3 months ago by Alexander Alekseev
Modified:
7 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Nikita (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Default keyboard layout should be set considering owners preference. BUG=chromium:280383 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M chromeos/ime/input_method_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Alexander Alekseev
Sometimes SigninScreenHandler::SetUserInputMethod(const std::string& username) is called with empty username (mostly because of lost focus). Before ...
7 years, 3 months ago (2013-08-28 06:29:20 UTC) #1
Dmitry Polukhin
LGTM but please also review with input_methods OWNERS.
7 years, 3 months ago (2013-08-28 18:09:05 UTC) #2
Alexander Alekseev
On 2013/08/28 18:09:05, Dmitry Polukhin wrote: > LGTM but please also review with input_methods OWNERS. ...
7 years, 3 months ago (2013-08-28 18:36:10 UTC) #3
Seigo Nonaka
lgtm
7 years, 3 months ago (2013-08-29 00:11:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/23608003/1
7 years, 3 months ago (2013-08-29 00:52:42 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=22929
7 years, 3 months ago (2013-08-29 01:03:11 UTC) #6
dzhioev (left Google)
lgtm
7 years, 3 months ago (2013-08-29 18:10:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/23608003/1
7 years, 3 months ago (2013-08-29 18:15:37 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-08-29 18:47:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/23608003/1
7 years, 3 months ago (2013-08-29 21:50:01 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 02:17:57 UTC) #11
Message was sent while issue was closed. 
Change committed as 220482

Powered by Google App Engine
This is Rietveld 408576698