Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 23604034: Consolidate 'variations' and 'variations_seed_proto' targets. (Closed)

Created:
7 years, 3 months ago by Alexei Svitkine (slow)
Modified:
7 years, 3 months ago
Reviewers:
jwd
CC:
chromium-reviews
Visibility:
Public.

Description

Consolidate 'variations' and 'variations_seed_proto' targets. Merges them to a single 'variations' target to simplify things. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M components/variations.gypi View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
7 years, 3 months ago (2013-09-04 18:57:37 UTC) #1
jwd
lgtm
7 years, 3 months ago (2013-09-05 15:28:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23604034/1
7 years, 3 months ago (2013-09-05 15:33:27 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 18:10:14 UTC) #4
Message was sent while issue was closed.
Change committed as 221457

Powered by Google App Engine
This is Rietveld 408576698