Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4159)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_browser.gypi

Issue 23604034: Consolidate 'variations' and 'variations_seed_proto' targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
===================================================================
--- chrome/chrome_browser.gypi (revision 220962)
+++ chrome/chrome_browser.gypi (working copy)
@@ -31,10 +31,10 @@
'../components/components.gyp:sessions',
'../components/components.gyp:startup_metric_utils',
'../components/components.gyp:user_prefs',
- # The direct variations_seed_proto dependency is needed, rather than
- # using common's dependency on variations, because the proto sources
- # need to be generated before code in this target can start building.
- '../components/components.gyp:variations_seed_proto',
+ # This depends directly on the variations target, rather than just
+ # transitively via the common target because the proto sources need to
+ # be generated before code in this target can start building.
+ '../components/components.gyp:variations',
'../components/components.gyp:visitedlink_browser',
'../components/components.gyp:visitedlink_common',
'../components/components.gyp:web_modal',
« no previous file with comments | « no previous file | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698