Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 23604019: reorder RenderWidgetHostViewPort::TextInputTypeChanged argument (Closed)

Created:
7 years, 3 months ago by yoichio
Modified:
7 years, 3 months ago
Reviewers:
sky, Yohei Yukawa, Jói, yukawa
CC:
chromium-reviews, jbauman+watch_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

reorder RenderWidgetHostViewPort::TextInputTypeChanged argument This CL is to intent that we have two different fields that represent input field attributes. BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yoichio
Could you stamp?
7 years, 3 months ago (2013-09-02 07:44:39 UTC) #1
yoichio
7 years, 3 months ago (2013-09-02 07:44:59 UTC) #2
yoichio
7 years, 3 months ago (2013-09-02 07:45:13 UTC) #3
Yohei Yukawa
lgtm
7 years, 3 months ago (2013-09-02 07:48:45 UTC) #4
yoichio
Add sky@ as an OWNER.
7 years, 3 months ago (2013-09-02 07:50:47 UTC) #5
yoichio
Add sky@ as content/browser/* OWNER. Add joi@ as content/port/* OWNER.
7 years, 3 months ago (2013-09-02 09:31:47 UTC) #6
Jói
//content/port LGTM. On Mon, Sep 2, 2013 at 11:31 AM, <yoichio@chromium.org> wrote: > Add sky@ ...
7 years, 3 months ago (2013-09-02 09:51:34 UTC) #7
sky
LGTM
7 years, 3 months ago (2013-09-03 16:11:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/23604019/1
7 years, 3 months ago (2013-09-03 22:43:24 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 03:06:27 UTC) #10
Message was sent while issue was closed.
Change committed as 221128

Powered by Google App Engine
This is Rietveld 408576698