content/browser/renderer_host/render_widget_host_view_win_browsertest.cc - Issue 23604019: reorder RenderWidgetHostViewPort::TextInputTypeChanged argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_win_browsertest.cc

Issue 23604019: reorder RenderWidgetHostViewPort::TextInputTypeChanged argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_win.cc ('k') | content/browser/renderer_host/test_render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_win_browsertest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_win_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_win_browsertest.cc

index 7a35dd829a9991ce32eb4f38f3966584703f0dc9..fc73601fb6c8b3b48709611f7455484b3d888ed3 100644

--- a/content/browser/renderer_host/render_widget_host_view_win_browsertest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_win_browsertest.cc

@@ -87,16 +87,16 @@ IN_PROC_BROWSER_TEST_F(RenderWidgetHostViewWinBrowserTest,

MockIMM32Manager* mock = new MockIMM32Manager();

mock->Reset();

view_->imm32_manager_.reset(mock);

- view_->TextInputTypeChanged(ui::TEXT_INPUT_TYPE_NONE, false,

- ui::TEXT_INPUT_MODE_EMAIL);

+ view_->TextInputTypeChanged(ui::TEXT_INPUT_TYPE_NONE,

+ ui::TEXT_INPUT_MODE_EMAIL, false);

EXPECT_EQ(1, mock->call_count());

EXPECT_EQ(view_->m_hWnd, mock->window_handle());

EXPECT_EQ(ui::TEXT_INPUT_MODE_EMAIL, mock->input_mode());

mock->Reset();

- view_->TextInputTypeChanged(ui::TEXT_INPUT_TYPE_NONE, false,

- ui::TEXT_INPUT_MODE_EMAIL);

+ view_->TextInputTypeChanged(ui::TEXT_INPUT_TYPE_NONE,

+ ui::TEXT_INPUT_MODE_EMAIL, false);

EXPECT_EQ(0, mock->call_count());

}